fix(web): surface fatal bootstrap snapshot failure#964
Draft
copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
Draft
fix(web): surface fatal bootstrap snapshot failure#964copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
copypasteitworks wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
the
vouch:unvouched
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #961
Summary
orchestration.getSnapshot()bootstrap failure instead of swallowing itRetry snapshot,Reload app, and expandable error detailsWhy
Today the first snapshot load can fail silently, which can leave the app unusable with no diagnosis or recovery path.
This PR keeps the fix tightly scoped to the initial web bootstrap path only.
Non-goals
UI Change
When the first snapshot load fails before any successful snapshot has loaded, the app now shows a blocking recovery view that mentions persisted state broadly (
T3CODE_STATE_DIR,CODEX_HOME, or other saved app state), exposes the backend error details, and allows retrying without reload.Validation
bun run test:browser src/routes/-__root.browser.tsxbun fmtbun lintbun typecheckNote
Show blocking recovery view when initial orchestration snapshot fails to load
EventRouterin__root.tsxnow tracks whether the firstgetSnapshotcall succeeded; on failure it sets an error state and defers bootstrap navigation until a successful retry.InitialSnapshotRecoveryViewcomponent renders a blocking UI with the error details and buttons to retry the snapshot or reload the app.-__root.browser.tsxusing MSW WebSocket/HTTP mocks to verify the recovery view appears on failure and disappears after a successful retry.Macroscope summarized b196590.